refactor: ♻️ ensure select field with data

lykmapipo · Jun 5, 2021 · d3f9727 · d3f9727
1 parent b2dfdf1
commit d3f9727
Showing 1 changed file with 21 additions and 25 deletions.
diff --git a/src/index.js b/src/index.js
@@ -420,35 +420,31 @@ export const populate = (options, done) => {
     async.waterfall(
       [
         // parse field selections
-        function parseSelect(next) {
+        (next) => {
           select(query, next);
         },
 
         // normalize populations
-        function normalize(selections, next) {
-          populations = _.map(populations, (population) => {
-            return (cb) => {
-              // obtain population selected fields
-              const fields = selections
-                ? selections[population.path]
-                : undefined;
-              if (fields) {
-                // eslint-disable-next-line no-param-reassign
-                population = _.merge({}, population, { select: fields });
-              }
-
-              // parse path specific select
-              if (population.select) {
-                select(population, (error, data) => {
-                  cb(error, _.merge({}, population, { data }));
-                });
-              }
-
-              // continue
-              else {
-                cb(null, population);
-              }
-            };
+        (selections, next) => {
+          populations = _.map(populations, (population) => (cb) => {
+            // obtain population selected fields
+            const fields = selections ? selections[population.path] : undefined;
+            if (fields) {
+              // eslint-disable-next-line no-param-reassign
+              population = _.merge({}, population, { select: fields });
+            }
+
+            // parse path specific select
+            if (population.select) {
+              select(population, (error, data) => {
+                cb(error, _.merge({}, population, { select: data }));
+              });
+            }
+
+            // continue
+            else {
+              cb(null, population);
+            }
           });
 
           async.parallel(populations, next);