Fixes an issue where kue-scheduler would throw an error and die when restore:true was set and a downstream error occurred
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes
```
TypeError: Cannot read property 'emit' of undefined
```
When `restore: true` in the `createQueue()` options object.
This was happening when an error was being passed, as the binding wasn't occuring in that instance. When I was able to output the error that was occurring, it was:
```
Error: All keys in the pipeline should belong to the same slot
at Pipeline.exec (/data/node_modules/ioredis/lib/pipeline.js:235:21)
at Pipeline.pipeline.exec (/data/node_modules/ioredis/lib/transaction.js:34:26)
at Queue.<anonymous> (/data/node_modules/kue-scheduler/index.js:1428:14)
From previous event:
at new Pipeline (/data/node_modules/ioredis/lib/pipeline.js:30:18)
at Cluster.redis.multi (/data/node_modules/ioredis/lib/transaction.js:24:20)
at Queue.<anonymous> (/data/node_modules/kue-scheduler/index.js:1420:32)
at runCallback (timers.js:800:20)
at tryOnImmediate (timers.js:762:5)
at processImmediate [as _immediateCallback] (timers.js:733:5)
```
Tests for #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
The specific error being thrown was
TypeError: Cannot read property 'emit' of undefinedbecausethiswasn't being bound todonewhen an error occurred.