feat(transports): ignore queue for pull transport

lib/message.model.js

@@ -882,6 +882,7 @@ MessageSchema.methods.queue = function queue(done) {
     //for actul send
     else if (message.mode === SEND_MODE_PULL) {
       worker.queue.emit('job queued', message);
+      return;
     }
 
     //queue message for later send
@@ -900,7 +901,7 @@ MessageSchema.methods.queue = function queue(done) {
       const job = message.runInBackground(jobDetails);
 
       //ensure message has been queued
-      job.save(function(error) {
+      return job.save(function(error) {
         if (error) {
           worker.queue.emit('job error', error);
           return cb(error);

lib/transports/smssync.js

@@ -17,7 +17,7 @@ const _ = require('lodash');
 const { getString, getBoolean } = require('@lykmapipo/env');
 const { smssync } = require('smssync');
 
-const { TYPE_SMS, SEND_MODE_PULL, STATE_SENT } = require('../common');
+const { TYPE_SMS, SEND_MODE_PULL } = require('../common');
 
 /**
  * @name defaults
@@ -151,9 +151,10 @@ exports._send = function(message, done) {
 exports.send = function(message, done) {
   // ensure message sender
   message.sender = message.sender || exports.name;
-  message.tyoe = TYPE_SMS;
+  message.type = TYPE_SMS;
   message.mode = SEND_MODE_PULL;
-  message.state = STATE_SENT;
+  // message.state = STATE_SENT;
+  // message.sentAt = new Date();
   message.queuedAt = new Date();
 
   // perform actual smssync sending

test/integration/message.queue.smssync.spec.js

@@ -0,0 +1,57 @@
+'use strict';
+
+/* dependencies */
+const { expect, clear } = require('@lykmapipo/mongoose-test-helpers');
+const { Message, worker } = require('../..');
+
+describe('smssync transport queue', () => {
+  before(() => {
+    delete process.env.DEBUG;
+  });
+
+  before(done => clear(done));
+  before(done => worker.clear(done));
+  before(done => worker.reset(done));
+  before(() => worker.start({ types: Message.TYPES }));
+
+  it('should be able to queue message', done => {
+    const message = Message.fakeExcept(
+      'sentAt',
+      'failedAt',
+      'queuedAt',
+      'deliveredAt',
+      'result'
+    );
+    message.transport = 'smssync';
+
+    // listen to queue events
+    worker.queue
+      .on('job queued', queued => {
+        expect(queued).to.exist;
+        expect(queued._id).to.be.eql(message._id);
+        expect(queued.to).to.exist;
+        expect(queued.to).to.be.eql(message.to);
+        expect(queued._id).to.exist;
+        // expect(queued.sentAt).to.exist;
+        expect(queued.deliveredAt).to.not.exist;
+        expect(queued.failedAt).to.not.exist;
+        // expect(queued.result).to.exist;
+        // expect(queued.result.success).to.exist;
+        // expect(queued.result.success).to.be.true;
+        done(null, queued);
+      })
+      .on('error', error => {
+        done(error);
+      });
+
+    message.queue();
+  });
+
+  after(done => worker.clear(done));
+  after(done => worker.stop(done));
+  after(done => clear(done));
+
+  after(() => {
+    delete process.env.DEBUG;
+  });
+});