feat: force E.164 format on phone numbers

lykmapipo · Jun 16, 2019 · 984a0d3 · 984a0d3
1 parent d60e1c4
commit 984a0d3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/transports/sms.infobip.js b/lib/transports/sms.infobip.js
@@ -18,6 +18,7 @@
 /* dependencies */
 const _ = require('lodash');
 const { getString } = require('@lykmapipo/env');
+const { toE164 } = require('@lykmapipo/phone');
 const Transport = require('bipsms');
 
 
@@ -124,7 +125,7 @@ exports._send = function (message, done) {
 
   //prepare destinations
   /*@todo ensure e164 format */
-  const to = message.to;
+  const to = toE164(message.to);
 
   //prepare infobip compliant sms payload
   const payload = _.merge({}, {
@@ -153,7 +154,8 @@ exports._send = function (message, done) {
 exports.send = function (message, done) {
 
   //update message with transport details
-  message.sender = message.sender || getString('SMS_INFOBIP_DEFAULT_SENDER_ID');
+  message.sender = message.sender || getString(
+    'SMS_INFOBIP_DEFAULT_SENDER_ID');
 
   //perform actual sms sending
   exports._send(message, done);

diff --git a/lib/transports/sms.tz.ega.js b/lib/transports/sms.tz.ega.js
@@ -18,6 +18,7 @@
 /* dependencies */
 const _ = require('lodash');
 const { getString } = require('@lykmapipo/env');
+const { toE164 } = require('@lykmapipo/phone');
 const transport = require('@lykmapipo/tz-ega-sms');
 
 
@@ -122,7 +123,9 @@ exports._send = function (message, done) {
 
   //prepare destinations
   /*@todo ensure e164 format */
-  const to = [].concat(message.to);
+  const to = _.map([].concat(message.to), phoneNumber => {
+    return toE164(phoneNumber);
+  });
 
   //prepare ega compliant sms payload
   const payload = _.merge({}, {