Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users who have +g set in the channel #135

Closed
wants to merge 1 commit into from

Conversation

ilbelkyr
Copy link
Contributor

There's a notification when users PM you while you're +g, but it isn't
always noticed - so highlight them in the channel as well.

There's a notification when users PM you while you're +g, but it isn't
always noticed - so highlight them in the channel as well.
@0xallie
Copy link
Contributor

0xallie commented May 20, 2015

Perhaps change it to "unset it or do /accept $botnick"? But otherwise, looks good.

@0xallie
Copy link
Contributor

0xallie commented May 20, 2015

Since even villagers are PMed now, this shouldn't reveal the existence of a special role, right?

@skizzerz
Copy link
Member

Maybe should check for CALLERID=g in ISUPPORT before enabling these hooks, but looking at other ircds out there none of them overload this numeric to mean something else so it should be fine as-is.

I echo @nyuszika7h's comment on adding /accept <botnick> to the sent message so they can allow lykos while still keeping +g on.

Finally, this code should really be in a different file (src/handler.py seems like a good candidate) so that the code is actually together rather than being intermixed with gameplay code. In the gameplay code itself you can add some events for on_start and after_role_pms then have the code in handler.py listen in on those events and insert the necessary IRC hooks.

@MishaCatskill
Copy link
Contributor

You need to do !myrole anyway to see what you missed, and if you do that in PM it'll accept lykos automatically.

@0xallie
Copy link
Contributor

0xallie commented May 26, 2015

(Label requested by @Vgr255. If you don't like it, blame him.)

@Vgr255
Copy link
Member

Vgr255 commented May 26, 2015

ಠ_ಠ

@0xallie 0xallie removed the not ready label May 26, 2015
@0xallie
Copy link
Contributor

0xallie commented Jun 22, 2015

pokes @ilbelkyr

@0xallie
Copy link
Contributor

0xallie commented Sep 9, 2015

Is this ever going to be done? :P

@skizzerz
Copy link
Member

Closing for now, reopen when ready.

@0xallie
Copy link
Contributor

0xallie commented Jan 11, 2016

There might be another problem. If someone sets +g after the first night PM, lykos might reveal that they are a special role, as villagers are only PMed on night 1.

@jacob1
Copy link
Member

jacob1 commented Jan 12, 2016

This only works night one anyway, and should probably stay that way for that reason. If they set +g after already receiving a PM, and then never do /accept, that is their fault ...

@skizzerz skizzerz deleted the umode_+g-warning branch November 8, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants