Nil values should remove attributes (instead of rendering as "null").

lynaghk · May 12, 2012 · 260e612 · 260e612
1 parent 5a756e5
commit 260e612
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/project.clj b/project.clj
@@ -1,4 +1,4 @@
-(defproject com.keminglabs/c2 "0.1.0"
+(defproject com.keminglabs/c2 "0.1.1-SNAPSHOT"
   :description "Declarative data visualization in Clojure(Script)."
   :url "http://keminglabs.com/c2/"
   :license {:name "BSD" :url "http://www.opensource.org/licenses/BSD-3-Clause"}

diff --git a/src/cljs/c2/dom.cljs b/src/cljs/c2/dom.cljs
@@ -168,9 +168,11 @@
                  (do (doseq [[k v] m] (attr el k v))
                      el)))
   ([el k v]
-     (if (= :style k)
-       (style el v)
-       (.setAttribute el (name k) v))
+     (if (nil? v)
+       (.removeAttribute el (name k))
+       (if (= :style k)
+         (style el v)
+         (.setAttribute el (name k) v)))
      el))
 
 (defn text