Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ice-pwd is null #18

Closed
fippo opened this issue Jul 11, 2013 · 3 comments
Closed

ice-pwd is null #18

fippo opened this issue Jul 11, 2013 · 3 comments
Labels

Comments

@fippo
Copy link

fippo commented Jul 11, 2013

Looking at a response sdp from a test installation running the latest commit (b014a1e) I see a null ice-pwd in the response sdp:
a=ice-pwd:(null)

I suppose chrome happily accepts the string "(null)" as ice-pwd, streams still work.

@fippo
Copy link
Author

fippo commented Jul 11, 2013

This seems to come from https://github.com/ging/licode/blob/master/erizo/src/erizo/NiceConnection.cpp#L117 -- not sure why the password is null here...

@lodoyun
Copy link
Contributor

lodoyun commented Jul 15, 2013

Yes, it works fine although it is not very "standary".
We are working on the cleanup branch that will do this and will close this issue when we make the switch.

Thanks!

@jcague
Copy link
Contributor

jcague commented Oct 11, 2013

It's changedin newer branches like cleanup and master. We'll switch them this week.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants