Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

story(sbb-form-field): support textarea #2497

Closed
kyubisation opened this issue Mar 18, 2024 · 0 comments · Fixed by #2506 or #2536
Closed

story(sbb-form-field): support textarea #2497

kyubisation opened this issue Mar 18, 2024 · 0 comments · Fixed by #2506 or #2536
Assignees
@dauriamarco
Labels
complexity: S Can be done in about a day proposal: accepted

Comments

@kyubisation
Copy link
Contributor

kyubisation commented Mar 18, 2024 •
edited

We want to support the textarea inside the <sbb-form-field>.
The default height should be 3 rows.
Allow vertical resize and disallow horizontal resize with resize: vertical;.

Figma: https://www.figma.com/file/9r6xSfNmEfCFxl1yFYedrj/Lyne-Components?type=design&node-id=32059%3A490070&mode=design&t=SVMnSxU2jC70fIaG-1

<sbb-form-field>
  <textarea>Example</textarea>
</sbb-form-field>
@kyubisation kyubisation added proposal: accepted complexity: S Can be done in about a day labels Mar 18, 2024
@dauriamarco dauriamarco self-assigned this Mar 19, 2024
@dauriamarco dauriamarco mentioned this issue Mar 19, 2024
Merged
jeripeierSBB pushed a commit that referenced this issue Apr 2, 2024
@dauriamarco
feat(sbb-form-field): support the textarea inside the `<sbb-form-fiel…
f8316f0 
…d>` (#2506)

Closes #2497

BREAKING CHANGE: The css var `--sbb-form-field-height` has been renamed to `--sbb-form-field-min-height`.
@github-actions github-actions bot mentioned this issue Apr 2, 2024
Merged
@github-actions github-actions bot mentioned this issue Jun 17, 2024
Closed
This was referenced Jun 25, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dauriamarco dauriamarco

Labels
complexity: S Can be done in about a day proposal: accepted
Projects
None yet
Milestone
No milestone
2 participants
@kyubisation @dauriamarco