Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate merging font faces with font-weight #2614

Closed
jeripeierSBB opened this issue Apr 24, 2024 · 0 comments · Fixed by #2618
Closed

Evaluate merging font faces with font-weight #2614

jeripeierSBB opened this issue Apr 24, 2024 · 0 comments · Fixed by #2618
Assignees
@jeripeierSBB
Milestone
Release 1.0.0

Comments

@jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB jeripeierSBB self-assigned this Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Merged
@jeripeierSBB jeripeierSBB added this to the Release 1.0.0 milestone Apr 25, 2024
jeripeierSBB added a commit that referenced this issue Apr 29, 2024
@jeripeierSBB
feat: reduce font-faces to single SBB variant (#2618)
679d9e9 
Closes #2614 

BREAKING CHANGE: Replaced `Roman`, `Bold`, and `Light` font-face variants with the single `SBB` font.
 Using CSS `font-weight` property automatically selects the correct font family.
 Migration guide:
  - Replace `font-family: "SBBWeb Roman", ...` with `font-family: "SBB", ...`  and use `font-weight: normal` (potentially not necessary as `normal` is the default).
  - Replace `font-family: "SBBWeb Bold", ...` with `font-family: "SBB", ...` and use `font-weight: bold` or CSS class `sbb-text--bold`.
  - Replace `font-family: "SBBWeb Light", ...` with `font-family: "SBB", ...` and use `font-weight: 300`.
  - Replace CSS variable `--sbb-typo-type-face-sbb-roman` with `--sbb-typo-font-family` and use `font-weight: normal` (potentially not necessary as `normal` is the default).
  - Replace CSS variable `--sbb-typo-type-face-sbb-bold` with `--sbb-typo-font-family` and use `font-weight: bold`.
  - Replace CSS variable `--sbb-typo-type-face-sbb-light` with `--sbb-typo-font-family` and use `font-weight: 300`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeripeierSBB jeripeierSBB

Labels
None yet
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging a pull request may close this issue.

feat: reduce font-faces to single SBB variant sbb-design-systems/lyne-components
1 participant
@jeripeierSBB