Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split CSS outputs into smaller modules #2615

Merged
merged 15 commits into from
Apr 29, 2024
Merged

feat: split CSS outputs into smaller modules #2615

merged 15 commits into from
Apr 29, 2024

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Apr 24, 2024

Closes #2601

BREAKING CHANGE: Renamed several files.

  • Renamed typography.css to standard-theme.css. Notice: there is still a file called typography.css that contains only a few typography-related outputs. Therefore, import adaption from typography.css to standard-theme.css is mandatory.
  • Changed the name of fullfont.css to font-characters-extension.css.

BEGIN_COMMIT_OVERRIDE
feat: split CSS outputs into smaller modules (#2615)

BREAKING CHANGE: As we split up the former typography.css into smaller consumable modules, we had to change the names of some files.

  • Renamed typography.css to standard-theme.css. Notice: there is still a file called typography.css that contains only a few typography-related outputs. Therefore, import adaption from typography.css to standard-theme.css is mandatory.
  • Changed the name of fullfont.css to font-characters-extension.css.
    END_COMMIT_OVERRIDE

@jeripeierSBB jeripeierSBB changed the title refactor: split css outputs into smaller modules [WIP] refactor: split css outputs into smaller modules Apr 24, 2024
@jeripeierSBB jeripeierSBB changed the title refactor: split css outputs into smaller modules feat: split css outputs into smaller modules Apr 24, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 24, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2615 April 24, 2024 13:46 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (e6397df) to head (0617bab).
Report is 33 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2615      +/-   ##
==========================================
+ Coverage   93.18%   93.23%   +0.04%     
==========================================
  Files         316      316              
  Lines       25389    25346      -43     
  Branches     2063     2070       +7     
==========================================
- Hits        23660    23631      -29     
+ Misses       1696     1682      -14     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I wonder if "global.css" is the best name. In the future, we might have a separate files for e.g. off-brand or lean context.
An option might be standard-theme.css.
What do you think?

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 25, 2024
@jeripeierSBB jeripeierSBB merged commit 646e5a4 into main Apr 29, 2024
22 checks passed
@jeripeierSBB jeripeierSBB deleted the refactor-typo branch April 29, 2024 08:05
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Apr 29, 2024
@jeripeierSBB jeripeierSBB changed the title feat: split css outputs into smaller modules feat: split CSS outputs into smaller modules Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Refactor typography.css to Focus on Essential Component Styles and Improve File Structure
3 participants