Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sbb-checkbox-group): set props instead of attributes in story #2529

Merged

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Mar 27, 2024

Preflight Checklist

Issue

This PR Closes #2499

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • callbacks on change now set 'checked' and 'indeterminate' props instead of attributes

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@602064c). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage        ?   93.19%           
=======================================
  Files           ?      301           
  Lines           ?    24921           
  Branches        ?     2029           
=======================================
  Hits            ?    23225           
  Misses          ?     1667           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Ps. I changed the title to docs(..):... because fix is a releasable unit and this change should not be part of the release changelog.
If you want to know more

@TomMenga TomMenga changed the title fix(sbb-checkbox-group): set props instead of attributes in story docs(sbb-checkbox-group): set props instead of attributes in story Mar 27, 2024
@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Mar 27, 2024
@TomMenga TomMenga removed the pr: peer review required A peer review is required for this pull request label Mar 27, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Mar 27, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 950b227 into main Mar 28, 2024
74 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the fix/broken-checkbox-group-indeterminate-story branch March 28, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: broken checkbox group indeterminate story
4 participants