fix: use valid import/export syntax #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using the common syntax of importing/exporting files without the extension. However, this is not natively supported in browsers and also not in Node.js with ESM. This change adds a linting rule that automatically adds the .js extension to any relative import.
github-actions
bot
added
the
pr: peer review required
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
=======================================
Coverage ? 93.22%
=======================================
Files ? 308
Lines ? 25309
Branches ? 2047
=======================================
Hits ? 23594
Misses ? 1683
Partials ? 32 ☔ View full report in Codecov by Sentry. |
jeripeierSBB
approved these changes
Apr 9, 2024
github-actions
bot
added
the
pr: lead review approved
TomMenga
approved these changes
Apr 9, 2024
github-actions
bot
added
pr: peer review approved
I'm torn between being proud and distraught 😅 |
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using the common syntax of importing/exporting files without the extension. However, this is not natively supported in browsers and also not in Node.js with ESM. This change adds a linting rule that automatically adds the .js extension
to any relative import.