Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve code sections by removing noise #2598

Merged
merged 28 commits into from
Apr 23, 2024
Merged

docs: improve code sections by removing noise #2598

merged 28 commits into from
Apr 23, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 18, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 18, 2024 09:44 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (e6397df) to head (69b82f6).
Report is 8 commits behind head on main.

❗ Current head 69b82f6 differs from pull request most recent head 7aec980. Consider uploading reports for the commit 7aec980 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2598   +/-   ##
=======================================
  Coverage   93.18%   93.19%           
=======================================
  Files         316      316           
  Lines       25389    25403   +14     
  Branches     2063     2063           
=======================================
+ Hits        23660    23674   +14     
  Misses       1696     1696           
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2598 April 18, 2024 10:45 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 18, 2024 11:59 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 18, 2024 12:43 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 18, 2024 13:06 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 18, 2024 13:24 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 04:58 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 05:50 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 06:50 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 07:40 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 08:32 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 09:11 Inactive
@github-actions github-actions bot requested a deployment to preview-pr2598 April 22, 2024 14:00 In progress
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 14:01 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 14:13 Inactive
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 22, 2024 14:32 Inactive
@jeripeierSBB jeripeierSBB changed the title docs: improve code sections by removing noise (WIP) docs: improve code sections by removing noise Apr 22, 2024
DavideMininni-Fincons
DavideMininni-Fincons reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

src/components/notification/notification.stories.ts Outdated Show resolved Hide resolved
src/components/toast/toast.stories.ts Show resolved Hide resolved
@jeripeierSBB @DavideMininni-Fincons
fix: review Davide
69b82f6 
Co-authored-by: Davide Mininni <101575400+DavideMininni-Fincons@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to preview-pr2598 April 23, 2024 08:33 Inactive
kyubisation
kyubisation approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 23, 2024
@jeripeierSBB jeripeierSBB merged commit ba4e696 into main Apr 23, 2024
21 checks passed
@jeripeierSBB jeripeierSBB deleted the refactor-stories-decorators branch April 23, 2024 08:50
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@DavideMininni-Fincons DavideMininni-Fincons Awaiting requested review from DavideMininni-Fincons

Assignees
No one assigned
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeripeierSBB @codecov-commenter @kyubisation @DavideMininni-Fincons