Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a release #972

Closed
zachfeldman opened this issue Oct 9, 2017 · 16 comments
Closed

Cut a release #972

zachfeldman opened this issue Oct 9, 2017 · 16 comments

Comments

@zachfeldman
Copy link
Contributor

We've merged a bunch of changes so sometime soon we should cut a new release.

@lynndylanhurley
Copy link
Owner

I'll pull down the latest and test with an actual client, then push out a beta release by the end of this week.

@zachfeldman
Copy link
Contributor Author

Good plan!

@MaicolBen
Copy link
Collaborator

I'm testing master as well with several projects that uses it (except Omniauth that we don't use it), for now I only found an issue #975

@MaicolBen
Copy link
Collaborator

Testing master I found failing some tests in a project because I don't have the new field allow_password_change, it was introduced here. What do I have to do? Shouldn't it check if recoverable is enabled?

@zachfeldman
Copy link
Contributor Author

@MaicolBen it probably should check if recoverable is enabled, that's a good point. Can you find a precedent in Devise or our codebase for how to check for a module being enabled?

@MaicolBen
Copy link
Collaborator

Yeah, it's possible, I made a PR #995

@Blitzkev
Copy link
Contributor

Blitzkev commented Nov 6, 2017

While we're waiting for a release to be cut (which would be really great), is there any way to use what's in master on github in a project? Pointing to here in the gemfile still makes it use 0.1.42 code

@MaicolBen
Copy link
Collaborator

@Blitzkev You can doing gem 'devise_token_auth', github: 'lynndylanhurley/devise_token_auth'

@lynndylanhurley Any ETA in testing and publishing the release? If we are following semver, this should be 0.2.0 because we have some new features merged in master

@ethagnawl
Copy link
Contributor

@Blitzkev The following is working for me:

gem "devise_token_auth", git: "https://github.com/lynndylanhurley/devise_token_auth", ref: "dc9456d99c2ea6f96323a95c87c1fee8f6cc857b"

@zachfeldman
Copy link
Contributor Author

Thanks for your patience all and @ethagnawl thanks for the workaround!

@lynndylanhurley
Copy link
Owner

Just pushed v0.1.43.beta1. I'll do extensive testing over the next couple of days and push v0.1.43 later this week.

In the meantime please pull down the beta and test.

Thanks!!

@MaicolBen
Copy link
Collaborator

Thanks @lynndylanhurley! can you take a look at #995, because it will break for the projects that update the gem. I would like #989 merged, but that's only for our projects.

@Blitzkev
Copy link
Contributor

Would appreciate this merged also:

#1021

@h4b00
Copy link

h4b00 commented Jan 8, 2018

@lynndylanhurley
when can we expect the next release?

@zachfeldman
Copy link
Contributor Author

@h4b00 have you tested v0.1.43.beta1 and has it been working well for you?

The more people test the beta branch, the faster we cut a release :).

@MaicolBen
Copy link
Collaborator

MaicolBen commented Mar 12, 2018

It was done, it's v0.1.43 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants