Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubocop linter to travis #1216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaicolBen
Copy link
Collaborator

Rubocop issues were fixed in #1125 but it wasn't added to travis, so we didn't fix the last issues with the new code changes.

@MaicolBen MaicolBen force-pushed the add-rubocop-linter branch 6 times, most recently from 74d1ffa to f6e1f7d Compare September 23, 2018 00:14
@dks17
Copy link
Contributor

dks17 commented Apr 6, 2019

This PR is useful for maintaining the repository. Try follow these steps:

  1. rebase
  2. delete .rubocop.yml and .rubocop_todo.yml
  3. run rubocop --auto-gen-conf
  4. add bundle exec rubocop below of this line
    - bundle install --jobs=3 --retry=3 --gemfile $GEMFILE_AR

And add rubocop step to Contribution Guidelines like: bundle exec rubocop -a and bundle exec rubocop --auto-gen-conf after change is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants