Resend confirmation instructions #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaicolBen
reviewed
Mar 18, 2019
|
@MaicolBen i rebased and fixed your comments. I had to force-push because of the rebase, is that ok? |
MaicolBen
approved these changes
Mar 19, 2019
| def create | ||
| return head :bad_request if params[:email].blank? | ||
|
|
||
| @resource = resource_class.dta_find_by(uid: params[:email].downcase, provider: provider) |
|
@MaicolBen @lpsBetty Doesn't this allow non authorised users to send confirmation emails for other users? Furthermore, if I understood the code correctly it doesn't check if the user has been already confirmed before re-sending the email. What is more, resource_params method is not needed since they are not mass assigned to the resource. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#920
#390