Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates: use update instead of update_attributes #1314

Merged
merged 1 commit into from Aug 10, 2019
Merged

updates: use update instead of update_attributes #1314

merged 1 commit into from Aug 10, 2019

Conversation

moray95
Copy link
Contributor

@moray95 moray95 commented Jul 15, 2019

Rails 6 deprecates update_attributes(!) (see ActiveRecord Deprecations). This pull request remove usages of update_attributes(!) in favor of update(!).

MaicolBen
MaicolBen approved these changes Aug 1, 2019
View reviewed changes
Copy link
Collaborator

@MaicolBen MaicolBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MaicolBen
Copy link
Collaborator

There were specs failing in master, rebased!

@MaicolBen MaicolBen merged commit f39244e into lynndylanhurley:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaicolBen MaicolBen MaicolBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moray95 @MaicolBen