Remove Rook open and semi-open bonus

lynx-chess · May 16, 2024 · c901fbb · c901fbb
1 parent df0c6b3
commit c901fbb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 19 deletions.
diff --git a/src/Lynx.Cli/appsettings.json b/src/Lynx.Cli/appsettings.json
@@ -66,14 +66,14 @@
       "MG": -17,
       "EG": -13
     },
-    "OpenFileRookBonus": {
-      "MG": 47,
-      "EG": 10
-    },
-    "SemiOpenFileRookBonus": {
-      "MG": 18,
-      "EG": 17
-    },
+    //"OpenFileRookBonus": {
+    //  "MG": 47,
+    //  "EG": 10
+    //},
+    //"SemiOpenFileRookBonus": {
+    //  "MG": 18,
+    //  "EG": 17
+    //},
     "BishopMobilityBonus": {
       "MG": 10,
       "EG": 9

diff --git a/src/Lynx/Configuration.cs b/src/Lynx/Configuration.cs
@@ -207,9 +207,9 @@ public sealed class EngineSettings
 
     public TaperedEvaluationTerm IsolatedPawnPenalty { get; set; } = new(-17, -13);
 
-    public TaperedEvaluationTerm OpenFileRookBonus { get; set; } = new(47, 10);
+    //public TaperedEvaluationTerm OpenFileRookBonus { get; set; } = new(47, 10);
 
-    public TaperedEvaluationTerm SemiOpenFileRookBonus { get; set; } = new(18, 17);
+    //public TaperedEvaluationTerm SemiOpenFileRookBonus { get; set; } = new(18, 17);
 
     public TaperedEvaluationTerm BishopMobilityBonus { get; set; } = new(10, 9);
 

diff --git a/src/Lynx/Model/Position.cs b/src/Lynx/Model/Position.cs
@@ -904,16 +904,16 @@ private int RookAdditionalEvaluation(int squareIndex, int pieceIndex)
 
         var packedBonus = attacksCount * Configuration.EngineSettings.RookMobilityBonus.PackedEvaluation;
 
-        const int pawnToRookOffset = (int)Piece.R - (int)Piece.P;
+        //const int pawnToRookOffset = (int)Piece.R - (int)Piece.P;
 
-        if (((PieceBitBoards[(int)Piece.P] | PieceBitBoards[(int)Piece.p]) & Masks.FileMasks[squareIndex]) == default)  // isOpenFile
-        {
-            packedBonus += Configuration.EngineSettings.OpenFileRookBonus.PackedEvaluation;
-        }
-        else if ((PieceBitBoards[pieceIndex - pawnToRookOffset] & Masks.FileMasks[squareIndex]) == default)  // isSemiOpenFile
-        {
-            packedBonus += Configuration.EngineSettings.SemiOpenFileRookBonus.PackedEvaluation;
-        }
+        //if (((PieceBitBoards[(int)Piece.P] | PieceBitBoards[(int)Piece.p]) & Masks.FileMasks[squareIndex]) == default)  // isOpenFile
+        //{
+        //    packedBonus += Configuration.EngineSettings.OpenFileRookBonus.PackedEvaluation;
+        //}
+        //else if ((PieceBitBoards[pieceIndex - pawnToRookOffset] & Masks.FileMasks[squareIndex]) == default)  // isSemiOpenFile
+        //{
+        //    packedBonus += Configuration.EngineSettings.SemiOpenFileRookBonus.PackedEvaluation;
+        //}
 
         return packedBonus;
     }