Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix engine crash due to a negative calculated time to move #555

Merged
merged 1 commit into from
Dec 31, 2023
Merged

🐛 Fix engine crash due to a negative calculated time to move #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Lynx/Engine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,15 @@ public async Task<SearchResult> BestMove(GoCommand goCommand)
{
// Inspired by Alexandria: time overhead to avoid timing out in the engine-gui communication process
millisecondsLeft -= 50;
Math.Clamp(millisecondsLeft, 50, int.MaxValue); // Avoiding 0/negative values
millisecondsLeft = Math.Clamp(millisecondsLeft, 50, int.MaxValue); // Avoiding 0/negative values

// 1/30, suggested by Serdra (EP discord)
decisionTime = Convert.ToInt32(Math.Min(0.5 * millisecondsLeft, (millisecondsLeft * 0.03333) + millisecondsIncrement));
}
else
{
millisecondsLeft -= 500;
Math.Clamp(millisecondsLeft, 50, int.MaxValue); // Avoiding 0/negative values
millisecondsLeft = Math.Clamp(millisecondsLeft, 50, int.MaxValue); // Avoiding 0/negative values

decisionTime = Convert.ToInt32((millisecondsLeft / goCommand.MovesToGo) + millisecondsIncrement);
}
Expand Down
45 changes: 27 additions & 18 deletions src/Lynx/Search/Helpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,27 +154,36 @@ private static int ScoreHistoryMove(int score, int rawHistoryBonus)
return score + rawHistoryBonus - (score * Math.Abs(rawHistoryBonus) / Configuration.EngineSettings.History_MaxMoveValue);
}

#pragma warning disable RCS1226 // Add paragraph to documentation comment
#pragma warning disable RCS1243 // Duplicate word in a comment
/// <summary>
/// When asked to copy an incomplete PV one level ahead, clears the rest of the PV Table+
/// PV Table at depth 3
/// Copying 60 moves
/// src: 250, tgt: 190
/// 0 Qxb2 Qxb2 h4 a8 a8 a8 a8 a8
/// 64 b1=Q exf6 Kxf6 a8 a8 a8 a8
/// 127 a8 b1=Q Qxb1 Qxb1 a8 a8
/// 189 Qxb1 Qxb1 Qxb1 a8 a8
/// 250 a8 Qxb1 a8 a8
/// 310 a8 a8 a8
///
/// PV Table at depth 3
/// 0 Qxb2 Qxb2 h4 a8 a8 a8 a8 a8
/// 64 b1=Q exf6 Kxf6 a8 a8 a8 a8
/// 127 a8 b1=Q Qxb1 Qxb1 a8 a8
/// 189 Qxb1 a8 a8 a8 a8
/// 250 a8 a8 a8 a8
/// 310 a8 a8 a8
/// </summary>
/// <param name="target"></param>
/// <param name="source"></param>
/// <param name="moveCountToCopy"></param>
#pragma warning restore RCS1243 // Duplicate word in a comment
#pragma warning restore RCS1226 // Add paragraph to documentation comment
[MethodImpl(MethodImplOptions.AggressiveInlining)]
private void CopyPVTableMoves(int target, int source, int moveCountToCopy)
{
// When asked to copy an incomplete PV one level ahead, clears the rest of the PV Table+
// PV Table at depth 3
// Copying 60 moves
// src: 250, tgt: 190
// 0 Qxb2 Qxb2 h4 a8 a8 a8 a8 a8
// 64 b1=Q exf6 Kxf6 a8 a8 a8 a8
// 127 a8 b1=Q Qxb1 Qxb1 a8 a8
// 189 Qxb1 Qxb1 Qxb1 a8 a8
// 250 a8 Qxb1 a8 a8
// 310 a8 a8 a8
//
// PV Table at depth 3
// 0 Qxb2 Qxb2 h4 a8 a8 a8 a8 a8
// 64 b1=Q exf6 Kxf6 a8 a8 a8 a8
// 127 a8 b1=Q Qxb1 Qxb1 a8 a8
// 189 Qxb1 a8 a8 a8 a8
// 250 a8 a8 a8 a8
// 310 a8 a8 a8
if (_pVTable[source] == default)
{
Array.Clear(_pVTable, target, _pVTable.Length - target);
Expand Down