Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Reimplement repetition detection #672

Closed
wants to merge 3 commits into from

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Feb 19, 2024

Reimplement repetition detection following the 'regular' method described in https://web.archive.org/web/20201107002606/https://marcelk.net/2013-04-06/paper/upcoming-rep-v2.pdf

Test  | perf/repetition-detection
Elo   | -6.26 +- 7.76 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.26 (-2.25, 2.89) [0.00, 5.00]
Games | N: 4940 W: 1543 L: 1632 D: 1765
Penta | [209, 554, 1011, 509, 187]
https://openbench.lynx-chess.com/test/174/

Test  | perf/repetition-detection
Elo   | -6.45 +- 7.75 (95%)
SPRT  | 40.0+0.40s Threads=1 Hash=128MB
LLR   | -2.26 (-2.25, 2.89) [0.00, 5.00]
Games | N: 4580 W: 1317 L: 1402 D: 1861
Penta | [145, 552, 969, 491, 133]
https://openbench.lynx-chess.com/test/175/

Again 8+0.08, just in case
Test  | perf/repetition-detection
Elo   | -9.34 +- 9.68 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -1.98 (-2.25, 2.89) [0.00, 5.00]
Games | N: 3050 W: 899 L: 981 D: 1170
Penta | [108, 377, 630, 309, 101]
https://openbench.lynx-chess.com/test/177/

Including #674 (Check IsCapture() and Move.Piece() type before checking 50 moves rule)

Test  | perf/repetition-detection-and-check-capture-and-move-Piece-before-repetition
Elo   | -3.58 +- 4.54 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | -2.27 (-2.25, 2.89) [0.00, 3.00]
Games | N: 13974 W: 4280 L: 4424 D: 5270
Penta | [494, 1627, 2877, 1507, 482]
https://openbench.lynx-chess.com/test/181/

@eduherminio
Copy link
Member Author

Closing in favor of #679

@eduherminio eduherminio deleted the perf/repetition-detection branch February 26, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant