Small UI fixes #164
Merged
Small UI fixes #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153. Fixes #154.
The flickering was caused by the CSS transition of the
transformon box hover. If you make the transition longer (I used 1000 seconds) you can inspect where the category selector goes off to. It's somewhere off-screen. Interestingly the magnifying glass icon stays in place.I'm not sure how this selector was positioned in the first place. It had a
float: leftproperty. But it's on the right? Anyway, I changed it toposition: absolute; right: 0;which makes more sense and also works even during the transition.As I was testing to make sure this works with all sorts of window sizes, I notice that a long workspace name subtly breaks a few things and looks ugly. I've changed it so this never happens. We rather truncate the workspace name with a "..." at the end.
The other thing driving me crazy was that clicking on something to open it from the directory browser just didn't work. Turns out this has been the case since 4.0.0 (f2a4450) but it only affects directories that have spaces in the name. (Like we're on Windows 95! 😄)
We don't want to reload the directory browser when it's just changing directories. So the linked commit added
skipReload()which will skip the controller reload on the next URL change. We callskipReload()before changing the URL to a different directory.Emphasis on "different": We also call it when changing from
Foo bartoFoo%20bar. But that does not actually trigger a URL change. So we will skip the controller reload on the URL change after that! E.g. when we are supposed to load the workspace.It's just terrible. For now I've just added a simple local fix. I guess there is a better way to do this, but I can't spend more time on it now.