Fix musl build errors #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build is failing with musl libc:
sysfs.cc:103:21: error: ‘basename’ was not declared in this scope
"/devices/" + basename(path.c_str());
That's because basename() is in <libgen.h> on musl libc.
Also, its argument is not const, so add const_cast.
Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
LONG_BIT is not a sysconf value, it is either 32 or 64. Using it as a sysconf value will give weird results. Originally it was sysconf(_SC_LONG_BIT) (before it was "fixed" by the gentoo guys). But this is useless: it will always return a value equal to LONG_BIT: it's either compiled 32-bit or 64-bit so a runtime lookup doesn't make sense. For this reason, musl has removed the definition of _SC_LONG_BIT. Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
woodsts
pushed a commit
to woodsts/buildroot
that referenced
this pull request
Jul 5, 2020
Remove patch 0001 (changes already upstream) and rework patches 0002 and 0003 (merge request sent upstream [1]) [1] lyonel/lshw#56 Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
jezze
pushed a commit
to jezze/buildroot
that referenced
this pull request
Aug 7, 2020
Remove patch 0001 (changes already upstream) and rework patches 0002 and 0003 (merge request sent upstream [1]) [1] lyonel/lshw#56 Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
celaxodon
pushed a commit
to celaxodon/buildroot
that referenced
this pull request
Oct 1, 2020
Remove patch 0001 (changes already upstream) and rework patches 0002 and 0003 (merge request sent upstream [1]) [1] lyonel/lshw#56 Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
awanga
pushed a commit
to awanga/alt-f-next
that referenced
this pull request
Oct 7, 2020
Remove patch 0001 (changes already upstream) and rework patches 0002 and 0003 (merge request sent upstream [1]) [1] lyonel/lshw#56 Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
|
merged upstream |
|
This breaks const correctness... musl's |
|
Opened #61 to deal with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.