-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: CompressedDataSubmitter #331
Open
antoncoding
wants to merge
17
commits into
master
Choose a base branch
from
fix/data-compressor
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoncoding
force-pushed
the
fix/data-compressor
branch
from
December 29, 2023 10:55
d075152
to
220ce5d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 97.94% 97.96% +0.01%
==========================================
Files 31 33 +2
Lines 1512 1575 +63
Branches 278 279 +1
==========================================
+ Hits 1481 1543 +62
Misses 3 3
- Partials 28 29 +1 ☔ View full report in Codecov by Sentry. |
antoncoding
force-pushed
the
fix/data-compressor
branch
from
January 3, 2024 06:04
b66eb78
to
30561ab
Compare
antoncoding
force-pushed
the
fix/data-compressor
branch
from
January 5, 2024 01:24
30561ab
to
1df382c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
submitTransfer
with theIDataReceiver
interface.FeedData
-> encode as bytes, and update a list of "feeds" with the data.IDecoder
interface to allow different feeds to further encode feed data differentlyDetails
VolFeedDecoder
is an example of how we can use the decoderTodo
ManagerData
array with manual encoding: (1408 bytes -> 1099 bytes)FeedData
with manual encoding (1099 bytes -> 351 bytes)Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot
forge fmt
forge test