Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Kubuntu 20.04 - bad .desktop #40

Closed
WesR opened this issue Sep 4, 2020 · 5 comments
Closed

Kubuntu 20.04 - bad .desktop #40

WesR opened this issue Sep 4, 2020 · 5 comments

Comments

@WesR
Copy link

WesR commented Sep 4, 2020

The environment variables are not set by default, causing the application not to launch. Also, just having the category "audio" does not add it to the multimedia category, and instead places it into "lost and found". Below is a working config for me.

Encoding=UTF-8
Version=1.0
Type=Application
Name=Lyrebird
GenericName=Voice Changer
Icon=/usr/share/lyrebird/icon.png
Exec=/usr/bin/lyrebird
Path=/usr/share/
Terminal=false
Categories=AudioVideo;Audio;
@ghost
Copy link

ghost commented Sep 4, 2020

Thanks for this, I'll merge it into the master branch soon. Can I ask what you meant by "environment variables are not set by default" though? To my knowledge Lyrebird doesn't require any environment variables to launch.

@WesR
Copy link
Author

WesR commented Sep 4, 2020

The icon, exec, and path part of the .desktop currently use bash variables. These lines in the current one:

Icon=${SHARE_PATH}/icon.png
Exec=${BIN_PATH}/lyrebird
Path=${SHARE_PATH}/

@ghost
Copy link

ghost commented Sep 4, 2020

@WesR The .desktop in the master branch is a template to be used with the installer script, each distro package also ships with a modified version. Agreed its not clear enough and will add a note to the README.

@WesR
Copy link
Author

WesR commented Sep 5, 2020

Sounds good. I would recommend that Categories=AudioVideo;Audio; gets updated in the template.

Also, that the variables be replaced in the .deb build.

ghost pushed a commit that referenced this issue Sep 11, 2020
@ghost
Copy link

ghost commented Sep 11, 2020

Also, that the variables be replaced in the .deb build.

Total screw up on my part! Fixed now, thanks for flagging!

@ghost ghost closed this as completed Sep 11, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant