Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Enabled auto_dump_assets. #20

Closed
wants to merge 1 commit into from
Closed

Conversation

umpirsky
Copy link
Contributor

assetic.options were overwriiten in app.php, and auto_dump_assets which is inside assetic.options, so they were not auto dumped.

I also updated dependencies.

@@ -36,9 +36,10 @@
"symfony/validator" : "2.1.*",
"symfony/yaml" : "2.1.*",
"symfony/config" : "2.1.*",
"symfony/finder" : "2.1.*",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add the finder ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember well, it fails if you don't add it, I think it is used to find assets.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it, everything is ok.
If it is really needed, the dependency should go to assetic package.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I open a PR on mheap/Silex-Assetic#6

@lyrixx
Copy link
Owner

lyrixx commented Sep 22, 2012

I'm 👍 with

- "fate/silex-extensions" : "dev-master"
+ "mheap/silex-assetic"   : "dev-master"

But not with auto_dump_assets. With this setting, application is really slower (from 300ms to 700ms). Do you know why ? what does this setting do ?

@umpirsky
Copy link
Contributor Author

@lyrixx Yes. But without that, assets were never dumped for me. How do you dump assets if auto_dump_assets is false? Maybe we can set 'auto_dump_assets' => $app['debug']?

@lyrixx
Copy link
Owner

lyrixx commented Sep 22, 2012

It is very strange. Before that update, this config key was not needed.
More over, the default value for auto_dump_assets is true

@lyrixx
Copy link
Owner

lyrixx commented Sep 22, 2012

OK, I check the code of AsseticExtension. Default options are deleted. I have to make another PR to this repo. But no time for now :(
Thanks for the PR, i fixed it in #ea522b9 .

@lyrixx lyrixx closed this Sep 22, 2012
@umpirsky
Copy link
Contributor Author

Yes, they are deleted in AsseticExtension, but maybe that's ok, if you override assetic.options, you override them all.

@umpirsky umpirsky mentioned this pull request Oct 2, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants