-
Notifications
You must be signed in to change notification settings - Fork 142
Conversation
@@ -36,9 +36,10 @@ | |||
"symfony/validator" : "2.1.*", | |||
"symfony/yaml" : "2.1.*", | |||
"symfony/config" : "2.1.*", | |||
"symfony/finder" : "2.1.*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add the finder ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember well, it fails if you don't add it, I think it is used to find assets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it, everything is ok.
If it is really needed, the dependency should go to assetic package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I open a PR on mheap/Silex-Assetic#6
I'm 👍 with
But not with |
@lyrixx Yes. But without that, assets were never dumped for me. How do you dump assets if |
It is very strange. Before that update, this config key was not needed. |
OK, I check the code of |
Yes, they are deleted in |
assetic.options
were overwriiten in app.php, andauto_dump_assets
which is insideassetic.options
, so they were not auto dumped.I also updated dependencies.