English updates and a Chinese string fault #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
问题：
1. {name} 没有翻译，所以英文界面本来应该是“Favorites list”在添加歌曲时显示的还是“我的收藏”
2. 搜索那一排“小芸搜索”之类的暗号，不清楚英文长度能否完全显示
|
刚刚发现一个string语言包里好像没有…… |
|
谢谢提供PR，是的，一些信息没有提取到语言包里面 |
lyswhut
reviewed
Mar 29, 2020
Comment on lines
1
to
4
| { | ||
| "min": "Minimize", | ||
| "close": "Close" | ||
| } |
There was a problem hiding this comment.
这里有什么变化吗？
没有。。翻译的时候是整个文件夹过的，可能也覆盖了……
lyswhut
reviewed
Mar 29, 2020
Comment on lines
2
to
29
| "theme_green": "Ocean Green", | ||
| "theme_blue": "Curious Blue", | ||
| "theme_yellow": "Confetti Yellow", | ||
| "theme_orange": "Saffron Orange", | ||
| "theme_red": "Valencia Red", | ||
| "theme_purple": "Wisteria Purple", | ||
| "theme_grey": "Slate Gray", | ||
| "theme_mid_autumn": "Chinese Goddess to the Moon", | ||
| "theme_naruto": "Naruto with Friends", | ||
| "theme_happy_new_year": "Happy Chinese New Year", | ||
|
|
||
| "source_kw": "Kuwo music", | ||
| "source_kg": "Kugou music", | ||
| "source_tx": "QQ music", | ||
| "source_wy": "NetEase Music", | ||
| "source_mg": "Migu Music", | ||
| "source_bd": "Baidu Music", | ||
|
|
||
| "source_all": "Meta Search", | ||
|
|
||
| "source_alias_kw": "KW Music", | ||
| "source_alias_kg": "KG Music", | ||
| "source_alias_tx": "Kyu×2 Music", | ||
| "source_alias_wy": "NY Music", | ||
| "source_alias_mg": "MG Music", | ||
| "source_alias_bd": "BD Music", | ||
|
|
||
| "source_alias_all": "Meta" |
There was a problem hiding this comment.
英文都是谷歌翻译翻的，主题名字太长会显示不全，所以使用尽量简即可，24行的Kyu×2 Music是什么鬼。。聚合搜索为什么翻译成meta呢？
There was a problem hiding this comment.
英文都是谷歌翻译翻的，主题名字太长会显示不全，所以使用尽量简即可，24行的
Kyu×2 Music是什么鬼。。聚合搜索为什么翻译成meta呢？
Kyux2:啊 因为英文习惯者可能知道QQ音乐但不清楚QQ跟腾讯的关系，所以起花名只好用Q的音Kyu来弄了…
聚合搜索……一般在英语里指的是“元搜索”引擎吧……
这些您来定
lyswhut
reviewed
Mar 29, 2020
| "select_all": "Select all", | ||
| "unselect_all": "Select none", | ||
| "name": "Name", | ||
| "progress": "Downloaded", |
lyswhut
reviewed
Mar 29, 2020
Comment on lines
9
to
10
| "lossless": "Lossless", | ||
| "high_quality": "High Quality", |
There was a problem hiding this comment.
这里显示的是音乐列表的音质标签，太长不好吧
好的
|
我去，我好像把那几个文件给删了。，。 |
算了，这次我就直接合了，下次先提交到dev分支，后面更新版本时我会再统一推到master分支 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
其他问题：
{name}没有翻译，所以英文界面本来应该是“Favorites list”在添加歌曲时显示的还是“我的收藏”