localfs NewWriter, should use O_TRUNC ?

[mh-cbon]

hi,

when i read the doc about NewWriter it says,

		// NewWriter returns a io.Writer that writes to a Cloud object
		// associated with this backing Store object.
		//
		// A new object will be created if an object with this name already exists.
		// Otherwise any previous object with the same name will be replaced.
		// The object will not be available (and any previous object will remain)
		// until Close has been called
		NewWriter(o string, metadata map[string]string) (io.WriteCloser, error)

however when using the localfs type, it appears the file is not truncated

• cloudstorage/localfs/store.go

  Line 247 in a14e59c

  return csbufio.OpenWriter(fo)

• cloudstorage/csbufio/writer.go

  Line 16 in b738f5f

  func OpenWriter(name string) (io.WriteCloser, error) {

What do you think ?

[araddon]

thanks for the report, and great write-up, will try to get some unit tests etc and address this soon.

[epsniff]

yep, thats a bug..

[epsniff]

@araddon Ill take this one, I should have a PR up tomorrow.