-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing the localfs reader writer truncate bug #52 #53
Conversation
My new testcases exposed a bug in SFTP so I'll fix that one tomorrow, in this pr. |
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 65.02% 64.89% -0.13%
==========================================
Files 13 13
Lines 1990 1997 +7
==========================================
+ Hits 1294 1296 +2
- Misses 488 491 +3
- Partials 208 210 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you!
Hi guys, i wonder why we d try to delete a file that does not exist.
Besides, i think this line https://github.com/lytics/cloudstorage/blob/master/sftp/store.go#L251 |
fixes #52
The localfs store wasn't correctly truncating the file when a new writer was created.