Version 0.0.3 - Bug fixes and DeckFactory added #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.0.3 comes with the following changes in this Pull Request and addresses opened issue #2
Changes
Adds the DeckFactory class which is used to create and manage multiple decks of cards. This class provides functionality for creating and keeping track of multiple Deck objects, each of which can be shuffled, dealt from, and managed independently. The factory allows you to easily create, shuffle, deal, and manage a collection of decks.
Modifies the shuffle() method to use a new unique SecureRandom seed each time it is called.
Modifies the getCards() method in the Hand class to return a modifiable list instead of unmodifiable
Fixes a bug reported in Issue Logic for some Deck tests seems flawed #2 where testShuffle() and testFindCard() were not checking the proper logic (e.g. checking index instead of the cards themselves.)