Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling move to top functionality #257

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Conversation

wbbradley
Copy link
Contributor

Hello, thanks for the great work with autoimport! This PR implements a bit of functionality I've been missing in autoimport, which is to allow users (through configuration) to disable the "move to top" feature.

Rationale

I am working in an large codebase that has several areas of circular dependencies, and at this stage, it is not a priority to detangle that mess. I understand and appreciate the value of "code as a DAG", however in this instance I'd still like to be able to leverage the other functionality in autoimport without having to prioritize cycle breaking in my project.

This issue has been raised here.

Checklist

  • Add test cases to all the changes you introduce
  • Update the documentation for the changes

@lyz-code
Copy link
Owner

Hi @wbbradley thanks for the PR.

I don't either have time right now to fix the issue sorry :(, you will probably be able to solve the issue by running make update

@lyz-code
Copy link
Owner

Alternatively you can disable the check in the CI if you want as I feel it's more important the easiness in contribution than the security

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9886215236

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 95.808%

Totals Coverage Status
Change from base Build 9029820318: 0.09%
Covered Lines: 320
Relevant Lines: 334

💛 - Coveralls

@wbbradley
Copy link
Contributor Author

I've gone ahead and bumped the versions of mkdocs and commitizen, and I've ignored the specific vulnerability found in the prior run but left all other checks running. Thanks for your help, and again, thanks for autoimport. Let me know if there are other steps I can take care of to help get it pushed up to pypi. And, I'm totally open to feedback on anything I did here. Mostly just tried to get my use-case unblocked.

Copy link
Owner

@lyz-code lyz-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the contribution (✿◠‿◠)

@lyz-code lyz-code merged commit ef49a03 into lyz-code:main Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants