Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #1024

Merged
merged 5 commits into from Aug 22, 2021
Merged

Minor cleanup #1024

merged 5 commits into from Aug 22, 2021

Conversation

a1346054
Copy link
Contributor

No description provided.

@t-mat
Copy link
Contributor

t-mat commented Aug 21, 2021

Hi @a1346054, thanks for your contribution.

Every change set looks good and straightforward. But I found minor issue for doc/lz4_manual.html.

https://github.com/a1346054/lz4/commit/f47bf9c72663647963ac26754236123a51904659#diff-b471b105cac7577745eb71a045a765fb1bec13ae7ae293ecba95589576a675d7R66

Since this file is automatically generated by contrib/gen_manual/gen_manual, cosmetic change for its output (doc/lz4_manual.html) doesn't resolve the issue.

If you want solve this, please fix gen_manual and commit its output.


I think the root cause of this cosmetic issue is print_line() outputs "blank" line which only contains spaces.

The following change may resolve the issue. But I'm not sure it satisfy your intention or not.

	void print_line(stringstream &sout, string line)
	{
+	    if (line.find_first_not_of(' ') == std::string::npos) line = "";
	    if (line.substr(0,11) == "LZ4LIB_API ") line = line.substr(11);
	    ...
	}

(edit) doc/lz4frame_manual.html is also generated by gen_manual.

@a1346054
Copy link
Contributor Author

I didn't want to touch the contrib files, so I now changed that commit so that it doesn't touch those autogenerated files.

@Cyan4973 Cyan4973 merged commit 1600ce5 into lz4:dev Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants