fix(module:select): remove duplicate drop-down menu options when nzMo…

…de === 'tags' (NG-ZORRO#3559) close NG-ZORRO#3559 * fix(module:select): remove duplicate drop-down menu options when nzMode === 'tags'(NG-ZORRO#3559)
lzdw · Jun 13, 2019 · 2331882 · 2331882
1 parent e59171b
commit 2331882
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/components/select/nz-select.service.ts b/components/select/nz-select.service.ts
@@ -182,17 +182,20 @@ export class NzSelectService {
       // https://github.com/NG-ZORRO/ng-zorro-antd/issues/3424
       this.listOfTagOption = [...this.listOfCachedSelectedOption, ...this.listOfSelectedValue].reduce(
         (options: NzOptionComponent[], componentOrValue) => {
+          // https://github.com/NG-ZORRO/ng-zorro-antd/issues/3559
           if (
             typeof componentOrValue === 'string' &&
-            !this.listOfTemplateOption.find(o => this.compareWith(o.nzValue, componentOrValue))
+            !this.listOfTemplateOption.find(o => this.compareWith(o.nzValue, componentOrValue)) &&
+            !options.some(o => o.nzValue === componentOrValue)
           ) {
             const nzOptionComponent = new NzOptionComponent();
             nzOptionComponent.nzValue = componentOrValue;
             nzOptionComponent.nzLabel = componentOrValue;
             options.push(nzOptionComponent);
           } else if (
             componentOrValue.nzValue &&
-            !this.listOfTemplateOption.find(o => this.compareWith(o.nzValue, componentOrValue.nzValue))
+            !this.listOfTemplateOption.find(o => this.compareWith(o.nzValue, componentOrValue.nzValue)) &&
+            !options.some(o => o.nzValue === componentOrValue.nzValue)
           ) {
             options.push(componentOrValue);
           }