Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new twitch helix API (app not working in the meantime) #17

Closed
madiele opened this issue Aug 15, 2021 · 6 comments · Fixed by #20
Closed

add support for new twitch helix API (app not working in the meantime) #17

madiele opened this issue Aug 15, 2021 · 6 comments · Fixed by #20

Comments

@madiele
Copy link
Contributor

madiele commented Aug 15, 2021

Twitch broke the v5 API so the switch is needed

I already implemented support for it in my own fork but since I also severely modified the logic and scope (changed some libraries and added/removed some features) I'll need some time to make a decent pull request, if you want me to make one let me know and I'll try to adapt the code and send one when I find some time for it

@tomasparks
Copy link

tomasparks commented Aug 15, 2021

Twitch broke the v5 API so the switch is needed

that's why my twitch vod downloader is not working.... :(

@madiele
Copy link
Contributor Author

madiele commented Aug 15, 2021

that's why my twitch vod downloader is not working.... :(

V5 is supported for another year or so, but they screwed with the API in the meantime by adding the need to be authenticated for every request, while before you could do some request with no authentication.

That's why lot's of stuff has been breaking everywhere

@lzeke0
Copy link
Owner

lzeke0 commented Aug 15, 2021

I wonder what made them do that since that information is publicly available on their website without any authentication whatsoever.

Anyway, pull requests are welcome however I wonder if it's better to just migrate to the new API anyway.

I won't be able to spend time with this for at least a week so, I guess we have to live with it for a while.

@madiele
Copy link
Contributor Author

madiele commented Aug 16, 2021

I did the pull request #20, check it out when you have time, some feature are missing but should at least do in the mean time

@christincooper
Copy link

@madiele Thank you very much for the pull request.

@lzeke0 Hope you gain the time to implement this fix on the live site soon so we can have the base up and running.

@misaalami
Copy link

misaalami commented Aug 19, 2021

I looked through the code adjustments by @madiele and it looks solid, great job!

ETA on having it approved here and pushed to the app? @lzeke0

Feel free to give me a shout if I can be of help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants