Remove Ding on delete backwards at start of line

We don't need to emulate GNU readline perfectly - and there are many complaints about this particular ding, so I've removed it. Fix #422
PowerShell · Jul 25, 2017 · 6c7c3fd · 6c7c3fd
1 parent 1cf7a00
commit 6c7c3fd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/PSReadLine/BasicEditing.cs b/PSReadLine/BasicEditing.cs
@@ -180,10 +180,6 @@ public static void BackwardDeleteChar(ConsoleKeyInfo? key = null, object arg = n
                 _singleton._current = startDeleteIndex;
                 _singleton.Render();
             }
-            else
-            {
-                Ding();
-            }
         }
 
         private void DeleteCharImpl(int qty, bool orExit)

diff --git a/UnitTestPSReadLine/BasicEditingTest.VI.cs b/UnitTestPSReadLine/BasicEditingTest.VI.cs
@@ -230,7 +230,7 @@ public void ViTestDelete()
                 "x", CheckThat(() => AssertCursorLeftIs(0))
                 ));
 
-            TestMustDing("0123", Keys(
+            Test("0123", Keys(
                 "0123", _.Escape,
                 "0X", CheckThat(() => AssertCursorLeftIs(0))
                 ));