Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orthonormalization Routines #296

Merged
merged 2 commits into from Sep 27, 2018
Merged

Orthonormalization Routines #296

merged 2 commits into from Sep 27, 2018

Conversation

kottmanj
Copy link
Contributor

Added orthonormalization routines to vmra.h
Added append function to vmra.h
Added cholesky and rr_cholesky for all types to lapack.cc and related files

Added orthonormalization routines and append function to vmra.h | add…
dcc54da 
…ed cholesky and rr_cholesky for all types to lapack
@fbischoff fbischoff self-assigned this Sep 26, 2018
fbischoff
fbischoff reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@fbischoff fbischoff left a comment •
edited by kottmanj

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two comments:

  1. you can replace
    Tensor X=inner(U,Ut,1,0);
    with
    Tensor X=inner(U,U,1,1);
    and avoid the explicit computation of Ut

No: U gets modified on the way

  1. indentation seems broken, run Source->correct indentation once

@fbischoff fbischoff merged commit 649c0b1 into master Sep 27, 2018
@fbischoff fbischoff deleted the pullreq-orthonormalization-routines branch September 27, 2018 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbischoff fbischoff fbischoff left review comments

Assignees

@fbischoff fbischoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kottmanj @fbischoff