Sandbox old api

[gfr10598]

This fixes the encoded date, broken in the last merge to master.
It seems to have a large impact on throughput, so we should try to understand that ASAP, but also should try to get the breakage fixed as soon as we understand.

---

This change is 

[coveralls]

Coverage increased (+0.02%) to 44.762% when pulling ec9a006 on sandbox-old-api into f507dee on master.

[yachang]

Reviewable status: 0 of 1 LGTMs obtained

---

annotator-ss.yaml, line 4 at r2 (raw file):

env: flex
service: annotatorss

Add a note to indicate that we need to do perf tuning for this one when we modify the annotator.yaml

[yachang]

Reviewable status: 0 of 1 LGTMs obtained

---

handler/handler.go, line 185 at r2 (raw file):

		}
	} else {
		responseMap = make(map[string]*api.GeoData)

if length of input request is 0, we can just return here.

[yachang]

Reviewable status: 0 of 1 LGTMs obtained

---

handler/handler.go, line 179 at r2 (raw file):

		// For old request format, we use empty date.
		date := time.Time{}
		responseMap, _, err = AnnotateLegacy(date, dataSlice)

It is not necessary to pass date as input param here. If I read the code correctly, it is useless at all.

[yachang]

Reviewable status: 0 of 1 LGTMs obtained

---

handler/handler.go, line 112 at r2 (raw file):

var ErrNoAnnotator = errors.New("no Annotator found")

// TODO move to annotatormanager package soon.

Add doc for input/output params

[yachang]

Reviewable status: complete! 1 of 1 LGTMs obtained

[gfr10598]

Reviewed 3 of 4 files at r1, 1 of 2 files at r2, 3 of 3 files at r3.
Reviewable status: complete! 1 of 1 LGTMs obtained

---

annotator-ss.yaml, line 4 at r2 (raw file):

Previously, yachang wrote…

Add a note to indicate that we need to do perf tuning for this one when we modify the annotator.yaml

Done.

---

handler/handler.go, line 112 at r2 (raw file):

Previously, yachang wrote…

Add doc for input/output params

Done.

---

handler/handler.go, line 179 at r2 (raw file):

Previously, yachang wrote…

It is not necessary to pass date as input param here. If I read the code correctly, it is useless at all.

Oops. That is remnant of code before I pulled out AnnotateLegacy.

---

handler/handler.go, line 185 at r2 (raw file):

Previously, yachang wrote…

if length of input request is 0, we can just return here.

We still have to encode the empty response map.

[yachang]

Reviewable status: complete! 1 of 1 LGTMs obtained