Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mutex for directory update. #228

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Add a mutex for directory update. #228

merged 2 commits into from
Apr 11, 2019

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Apr 10, 2019 •
edited by shelbychen97
Loading

Without this, it appears that there are two threads trying to concurrently build the directory at startup, causing an OOM.

This change is Reviewable

@gfr10598 gfr10598 requested a review from yachang April 10, 2019 21:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2144

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 53.877%
Changes Missing Coverage Covered Lines Changed/Added Lines %
manager/manager.go 0 6 0.0%
Totals Coverage Status
Change from base Build 2137: -0.2%
Covered Lines: 1063
Relevant Lines: 1973
💛 - Coveralls

yachang
yachang reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

yachang
yachang approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@yachang yachang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@gfr10598 gfr10598 merged commit b09f2f5 into master Apr 11, 2019
@gfr10598 gfr10598 deleted the sandbox-update-mutex branch April 11, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yachang yachang yachang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gfr10598 @coveralls @yachang