Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to reannotator for hopannotation1 datatype #27

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Apr 21, 2023

This change adds support for the hopannotation1 datatype to the reannotator command. This change also adds a new query to return all hopannotation1 archives to be processed by the reannotator. And, finally this change updates the flags given to the reannotator Kubernetes job to include the new query and hopannotation1 dataype.


This change is Reviewable

@stephen-soltesz stephen-soltesz force-pushed the sandbox-soltesz-hop-annotation-proc branch from e30ef37 to 75c1786 Compare April 21, 2023 15:37
@stephen-soltesz stephen-soltesz force-pushed the sandbox-soltesz-hop-reannotator-main-cfg branch from 632391c to 13d22be Compare April 21, 2023 15:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 309

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.961%

Totals Coverage Status
Change from base Build 305: 0.0%
Covered Lines: 784
Relevant Lines: 817

💛 - Coveralls

Base automatically changed from sandbox-soltesz-hop-annotation-proc to main April 21, 2023 15:52
@stephen-soltesz stephen-soltesz force-pushed the sandbox-soltesz-hop-reannotator-main-cfg branch from 13d22be to edf1d3f Compare April 21, 2023 15:53
@stephen-soltesz stephen-soltesz marked this pull request as ready for review April 21, 2023 15:59
Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 7769bbb into main Apr 21, 2023
4 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-hop-reannotator-main-cfg branch April 21, 2023 18:23
@stephen-soltesz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants