Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds hostname as key in the generated registration.json #18

Merged
merged 2 commits into from
May 6, 2024
Merged

Adds hostname as key in the generated registration.json #18

merged 2 commits into from
May 6, 2024

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented May 6, 2024 •
edited by stephen-soltesz

This PR fixes the structure of registration.json so it uses the hostname as key (as expected by heartbeat).

Also, adds -output to set the output folder for generated config files.

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented May 6, 2024 •
edited

Pull Request Test Coverage Report for Build 8974316790

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 8974205984: 0.0%
Covered Lines: 506
Relevant Lines: 506
💛 - Coveralls

cristinaleonr
cristinaleonr approved these changes May 6, 2024
View reviewed changes
Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@robertodauria robertodauria merged commit c75ebcc into main May 6, 2024
8 checks passed
@robertodauria robertodauria deleted the sandbox-roberto-add-hostname-key branch May 6, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristinaleonr cristinaleonr cristinaleonr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertodauria @coveralls @cristinaleonr