-
Notifications
You must be signed in to change notification settings - Fork 5
Fix travis integration for netifaces and netsnmp modules. #41
Conversation
Reviewed 5 of 5 files at r1. fake-packages/netifaces.py, line 1 [r1] (raw file): Comments from Reviewable |
Review status: 2 of 6 files reviewed at latest revision, 1 unresolved discussion. fake-packages/netifaces.py, line 1 [r1] (raw file): I've added fake-packages/README.md and links to the future location of the README under the Comments from Reviewable |
Reviewed 2 of 4 files at r2, 2 of 2 files at r3. .travis.yml, line 19 [r3] (raw file): Comments from Reviewable |
Review status: 3 of 6 files reviewed at latest revision, 2 unresolved discussions. .travis.yml, line 19 [r3] (raw file): Comments from Reviewable |
As a security precaution, travis-ci maintains a whitelist of packages that can be installed for tests. Any package not on the whitelist cannot be installed for CI testing. The Ubuntu packages
python-netifaces
andpython-netsnmp
are not on the whitelist. Similarly, the pip packages fornetifaces
andnetsnmp
cannot build because their dependencies are not whitelisted either, e.g. libsnmp-dev.Since these packages involve network discovery and system introspection (potential security risks), it is unlikely that travis would whitelist these packages or their dependencies in the future.
So, to work around this limitation, this change adds minimal skeleton versions of each package so that we can still run tests within travis-ci.
From the
.travis.yml
file, thebuild
script is given a fake module path. And, thebuild
script itself should remain unmodified so that local installations can still run unit tests with the true versions ofnetifaces
andnetsnmp
.This change is