Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme for dp network #195

Merged
merged 2 commits into from
Oct 31, 2019
Merged

update readme for dp network #195

merged 2 commits into from
Oct 31, 2019

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Oct 30, 2019

Since mlab-staging has a misconfigured default network, this updates the gcloud commands to use the data-processing/dp-gardener network/subnet.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Oct 30, 2019

Pull Request Test Coverage Report for Build 1598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 45.138%

Files with Coverage Reduction New Missed Lines %
cloud/bq/dedup.go 1 41.84%
Totals Coverage Status
Change from base Build 1594: 0.2%
Covered Lines: 687
Relevant Lines: 1522

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: - with comments.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @gfr10598 and @stephen-soltesz)


README.md, line 44 at r1 (raw file):

```bash
gcloud --project=mlab-sandbox \

Looks like I missed this in the previous PR with .md commands.

Throughout, please format the commands as if they were in a shell script. This should include indentation on continued lines. For example:

some "long command" \
    --with-extra flags \
    --with-extra indentation

README.md, line 58 at r1 (raw file):

```bash
gcloud --project=mlab-sandbox compute addresses create etl-gardener --region=us-east1 --subnet=dp-gardener --addresses=10.100.1.2

nit: please use line continuation.

@gfr10598 gfr10598 merged commit 3fa6efd into master Oct 31, 2019
@gfr10598 gfr10598 deleted the sandbox-update-readme branch October 31, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants