Separate integration tests #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: the cloud build trigger failed on the status checks b/c this branch does not yet include a cloudbuild.yaml config. |
robertodauria
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is 1 of 2 changes that migrate etl-gardener from travis to cloudbuild deployments.
This change removes support for deployments from travis and adds better integration testing support. It turned out that many files require service account credentials than were implied by the unit test file names. This change updates all files that fail without SA credentials to be part of the "integration" test builds. Future work should segregate tests into the correctly named files.
This change is