Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize jobs total metric on startup. #402

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jul 26, 2022

Recently, we have observed alerts like https://github.com/m-lab/dev-tracker/issues/724 due to longer datatype processing times and existing short alert wait times. We want to know quickly whether the gardener service is down. So, this change initializes the gardener_jobs_total metric at startup so that it exists without interfering with existing alerts.


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3522

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 74.117%

Totals Coverage Status
Change from base Build 3510: 0.01%
Covered Lines: 1532
Relevant Lines: 2067

💛 - Coveralls

@stephen-soltesz stephen-soltesz marked this pull request as ready for review July 26, 2022 19:39
Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 88c1fe2 into master Jul 26, 2022
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-jobs-total-init branch July 26, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants