Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dataset pkg #424

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Remove dataset pkg #424

merged 3 commits into from
Apr 13, 2023

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Apr 12, 2023 •
edited

This change removes the only remaining references to the go/dataset package by including error declarations in cloud/bq/ops.go instead.

This change is Reviewable

@stephen-soltesz
Copy link
Contributor Author

Part of:

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3650

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.442%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cloud/bq/ops.go 0 9 0.0%
Totals Coverage Status
Change from base Build 3646: 0.0%
Covered Lines: 1259
Relevant Lines: 1605
💛 - Coveralls

cristinaleonr
cristinaleonr approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 3a043e0 into main Apr 13, 2023
4 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-remove-dataset-pkg branch April 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristinaleonr cristinaleonr cristinaleonr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephen-soltesz @coveralls @cristinaleonr