Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1 logic from etl packages: fake, bq, and related tests #1086

Merged
merged 4 commits into from
Jun 3, 2022

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jun 2, 2022

This change completes a TODO from #1080 in the worker_test.go to use a fakestorage server to make what was previously an "integration" test a standard, in-memory unit test.

This change also removes two packages that are now unnecessary:

  • bq - which managed inserts into BigQuery tables, via a Put() method
  • fake - which implemented an in-memory interface of the bq package's Put() method for unit tests.

Part of:


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7320

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 65.542%

Files with Coverage Reduction New Missed Lines %
active/active.go 2 90.63%
Totals Coverage Status
Change from base Build 7318: -0.7%
Covered Lines: 3631
Relevant Lines: 5540

💛 - Coveralls

Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 259f3fa into master Jun 3, 2022
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-remove-v1-2 branch June 3, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants