Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MinRTT to milliseconds #1129

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Nov 28, 2023

This change corrects a bug in the calculation of the summary record for ndt5 MinRTT.

Previously the value was divided by 1000 twice, which unintentionally converted microsecond resolution value to seconds, when milliseconds was intended.

Part of:


This change is Reviewable

Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz
Copy link
Contributor Author

Thank you!

@stephen-soltesz stephen-soltesz merged commit 75bf073 into main Nov 28, 2023
5 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-ndt5-minrtt-fix branch November 28, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants