Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label the Locate API name with deployment environment #178

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Feb 5, 2024

This change labels the deployment environment with the sandbox or staging project name or simply "Production" for M-Lab's production environment.

This change will help us distinguish between the different deployments internally, and signal to third parties that the "Production" API is for production use.

Without:
Screenshot 2024-02-05 at 11 32 42 AM

With:
Screenshot 2024-02-05 at 11 56 32 AM


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 1247

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.637%

Totals Coverage Status
Change from base Build 1245: 0.0%
Covered Lines: 1753
Relevant Lines: 1814

💛 - Coveralls

@stephen-soltesz stephen-soltesz marked this pull request as ready for review February 5, 2024 17:30
Copy link
Contributor

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 :lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 6571b4e into main Feb 5, 2024
7 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-api-name branch February 5, 2024 18:39
@stephen-soltesz
Copy link
Contributor Author

Ultimately, all APIs are named:

Screenshot 2024-02-07 at 3 50 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants