Migrate mlab-ns to the new siteinfo API #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkinkade
approved these changes
Jun 6, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the SITE_LIST_URLs & IP_LIST_URLs for the update handlers to read from the siteinfo API. The content of the source files are unchanged.
This change also updates the IP_LIST_URLs from a .txt file to the .json file. Unit tests to exercise the code changes are also included here.
This change is