Fix Dockerfile to remain py2.7 compatible #218
Conversation
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 LGTMs obtained (waiting on @nkinkade and @stephen-soltesz)
Dockerfile, line 15 at r1 (raw file):
RUN rm -f google-cloud-sdk-277.0.0-linux-x86_64.tar.gz ENV PATH $PATH:/usr/local/google-cloud-sdk/bin RUN gcloud components install app-engine-python app-engine-python-extras
Out of curiosity, how does gcloud know that it should be installing these components under /usr/local as opposed to /usr/lib? I notice that google-cloud-sdk-277.0.0-linux-x86_64.tar.gz does not contain a platform/google_appengine directory, so it be coming from this gcloud components install command. Does it know where to install things because gcloud inspects its own location in the filesystem?
There was a problem hiding this comment.
Reviewable status:
Dockerfile, line 15 at r1 (raw file):
Previously, nkinkade wrote…
Out of curiosity, how does
gcloudknow that it should be installing these components under/usr/localas opposed to/usr/lib? I notice thatgoogle-cloud-sdk-277.0.0-linux-x86_64.tar.gzdoes not contain aplatform/google_appenginedirectory, so it be coming from thisgcloud components installcommand. Does it know where to install things becausegcloudinspects its own location in the filesystem?
That's right -- gcloud looks up its own path and the components install writes the new files to /usr/local/goole-cloud-sdk/...
|
Fixes #217 (kind of, but still leaves the 2.7 timebomb in place) |
The previous base image no longer supports python2.7 natively.
This change updates the Dockerfile to remain py2.7 compatible for a little longer.
This change is