Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /v2/platform/* dispatch rules #244

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jun 30, 2020

This change updates the dispatch.yml rules that impact how /v2/* requests are routed to the locate and locate-platform services. This change is step 3 of https://github.com/m-lab/dev-tracker/issues/600

Currently monitoring requests issued to /v2/platform/monitoring are actually routed to the "locate" service. This change ensures that those requests are delivered to the locate-platform service.

This change is necessary to allow us to manage the user-visible APIs in the locate service using Cloud Endpoints (e.g. /v2/nearest), without exposing users to extraneous API calls needed to manage the platform (e.g. monitoring).


This change is Reviewable

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 LGTMs obtained

@stephen-soltesz stephen-soltesz merged commit dd03a84 into master Jun 30, 2020
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-dispatch-platform branch August 12, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants